feat: remove toNat lemmas from bitvec_rules #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Siddharth Bhat<[email protected]> Co-Authored-By: Alex Keizer<[email protected]>
alexkeizer
force-pushed
the
remove-toNat-bitvec-rules
branch
from
c708b8e to
df94680
Compare
shigoel
reviewed
Oct 3, 2024
bollu
added a commit
to opencompl/lean4
that referenced
this pull request
Oct 3, 2024
These were missing from the `bv_toNat` simp-set, discovered when refactoring LNSym's simp-set: leanprover/LNSym#208
github-merge-queue bot
pushed a commit
to leanprover/lean4
that referenced
this pull request
Oct 3, 2024
These were missing from the `bv_toNat` simp-set, discovered when refactoring LNSym's simp-set: leanprover/LNSym#208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents us from unfolding expressions that have
.toNatinto gigantic expressions. Furthermore, this helpsbv_decide, since it can see pure bitvector statements.